Co-Pilot / 辅助式
更新于 a month ago

requesting-code-review

Oobra
28.1k
obra/superpowers/skills/requesting-code-review
76
Agent 评分

💡 摘要

一个工作流技能,用于在继续开发或合并前,调度代码审查子代理以根据计划验证变更。

🎯 适合人群

AI辅助的软件开发人员管理AI代理的技术负责人自动化审查关卡的DevOps工程师寻求质量保证的独立开发者

🤖 AI 吐槽:这就像一个让你请AI朋友检查作业的豪华待办清单,不过至少这位朋友很守纪律。

安全分析低风险

该技能会调度一个可能执行代码的子代理;必须确保'code-reviewer'子代理来自可信源并在沙箱环境中运行,以防止任意代码执行。需审查子代理自身对文件系统和网络访问的权限。


name: requesting-code-review description: Use when completing tasks, implementing major features, or before merging to verify work meets requirements

Requesting Code Review

Dispatch superpowers:code-reviewer subagent to catch issues before they cascade.

Core principle: Review early, review often.

When to Request Review

Mandatory:

  • After each task in subagent-driven development
  • After completing major feature
  • Before merge to main

Optional but valuable:

  • When stuck (fresh perspective)
  • Before refactoring (baseline check)
  • After fixing complex bug

How to Request

1. Get git SHAs:

BASE_SHA=$(git rev-parse HEAD~1) # or origin/main HEAD_SHA=$(git rev-parse HEAD)

2. Dispatch code-reviewer subagent:

Use Task tool with superpowers:code-reviewer type, fill template at code-reviewer.md

Placeholders:

  • {WHAT_WAS_IMPLEMENTED} - What you just built
  • {PLAN_OR_REQUIREMENTS} - What it should do
  • {BASE_SHA} - Starting commit
  • {HEAD_SHA} - Ending commit
  • {DESCRIPTION} - Brief summary

3. Act on feedback:

  • Fix Critical issues immediately
  • Fix Important issues before proceeding
  • Note Minor issues for later
  • Push back if reviewer is wrong (with reasoning)

Example

[Just completed Task 2: Add verification function]

You: Let me request code review before proceeding.

BASE_SHA=$(git log --oneline | grep "Task 1" | head -1 | awk '{print $1}')
HEAD_SHA=$(git rev-parse HEAD)

[Dispatch superpowers:code-reviewer subagent]
  WHAT_WAS_IMPLEMENTED: Verification and repair functions for conversation index
  PLAN_OR_REQUIREMENTS: Task 2 from docs/plans/deployment-plan.md
  BASE_SHA: a7981ec
  HEAD_SHA: 3df7661
  DESCRIPTION: Added verifyIndex() and repairIndex() with 4 issue types

[Subagent returns]:
  Strengths: Clean architecture, real tests
  Issues:
    Important: Missing progress indicators
    Minor: Magic number (100) for reporting interval
  Assessment: Ready to proceed

You: [Fix progress indicators]
[Continue to Task 3]

Integration with Workflows

Subagent-Driven Development:

  • Review after EACH task
  • Catch issues before they compound
  • Fix before moving to next task

Executing Plans:

  • Review after each batch (3 tasks)
  • Get feedback, apply, continue

Ad-Hoc Development:

  • Review before merge
  • Review when stuck

Red Flags

Never:

  • Skip review because "it's simple"
  • Ignore Critical issues
  • Proceed with unfixed Important issues
  • Argue with valid technical feedback

If reviewer wrong:

  • Push back with technical reasoning
  • Show code/tests that prove it works
  • Request clarification

See template at: requesting-code-review/code-reviewer.md

五维分析
清晰度8/10
创新性6/10
实用性9/10
完整性7/10
可维护性8/10
优缺点分析

优点

  • 强制执行有纪律的、增量式的审查周期
  • 直接集成到AI驱动的开发工作流中
  • 清晰的反馈升级和行动指南

缺点

  • 严重依赖底层'code-reviewer'子代理的质量
  • 对于非常简单的变更会增加开销
  • 需要git历史和提交纪律

相关技能

claude-ctx-plugin

A
toolAuto-Pilot / 全自动
84/ 100

“这个插件如此全面,很可能拥有一个管理自身存在性焦虑的技能。”

pytorch

S
toolCode Lib / 代码库
92/ 100

“它是深度学习的瑞士军刀,但祝你好运能从47种安装方法里找到那个不会搞崩你系统的那一个。”

agno

S
toolCode Lib / 代码库
90/ 100

“它承诺成为智能体领域的Kubernetes,但得看开发者有没有耐心学习又一个编排层。”

免责声明:本内容来源于 GitHub 开源项目,仅供展示和评分分析使用。

版权归原作者所有 obra.